Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Monitoring plugin cluster alerts to not install by default #79657

Merged
merged 2 commits into from
Oct 25, 2021

Conversation

jbaiera
Copy link
Member

@jbaiera jbaiera commented Oct 21, 2021

Changes the default monitoring watches to not be installed by default any more. Tests have been updated to continue installing watches to make sure the installation process continues to work.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

Copy link
Contributor

@danhermann danhermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There's one unnecessary comma in the error message on the line below that pains my grammatical sensibilities 😅, but handle it as you prefer.

https://github.com/elastic/elasticsearch/pull/79657/files#diff-2e3dc92810df221c2506d5a489cb769f3fdd7fb57ee4e8ad307a60d1b049f430R403

@jbaiera
Copy link
Member Author

jbaiera commented Oct 25, 2021

pains my grammatical sensibilities

Overuse of commas is abhorrent and should be eschewed.

@jbaiera jbaiera merged commit b519351 into elastic:master Oct 25, 2021
@jbaiera jbaiera deleted the monitoring-no-alerts-default branch October 25, 2021 20:01
lockewritesdocs pushed a commit to lockewritesdocs/elasticsearch that referenced this pull request Oct 28, 2021
…astic#79657)

Changes the default monitoring watches to not be installed by default any 
more. Tests have been updated to continue installing watches to make sure
the installation process continues to work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants