Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressing assertion failure, 'downgrading' to exception - enrich #79717

Conversation

mjmbischoff
Copy link
Contributor

Addressing assertion failure, 'downgrading' to exception by moving call to try catch. Fixes "java.lang.AssertionError: java.lang.AssertionError: callback must handle its own exceptions"

Discovered in #79607

… to try catch. Fixes "java.lang.AssertionError: java.lang.AssertionError: callback must handle its own exceptions"
@mjmbischoff mjmbischoff requested a review from martijnvg October 25, 2021 14:13
@elasticsearchmachine elasticsearchmachine added v8.0.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Oct 25, 2021
@martijnvg martijnvg added >bug v7.16.1 :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP labels Oct 25, 2021
@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Oct 25, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mjmbischoff mjmbischoff merged commit 809c13f into elastic:master Oct 25, 2021
@mjmbischoff mjmbischoff deleted the Downgrading_failed_assertion_to_exception_enrich branch October 25, 2021 15:21
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
7.16

@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

The backport operation could not be completed due to the following error:
There are no branches to backport to. Aborting.

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 79717

elasticsearchmachine pushed a commit that referenced this pull request Oct 25, 2021
…9717) (#79724)

Addressing assertion failure, 'downgrading' to Exception by moving to try catch. Fixes "java.lang.AssertionError: java.lang.AssertionError: callback must handle its own exceptions"
lockewritesdocs pushed a commit to lockewritesdocs/elasticsearch that referenced this pull request Oct 28, 2021
…astic#79717)

 Addressing assertion failure, 'downgrading' to Exception by moving to try catch. Fixes "java.lang.AssertionError: java.lang.AssertionError: callback must handle its own exceptions"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Data Management Meta label for data/management team v7.16.0 v8.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants