[ML] simplifying model license checks #80031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (Team:ML) |
rjernst
approved these changes
Oct 28, 2021
| @@ -268,7 +268,7 @@ public InferencePipelineAggregationBuilder rewrite(QueryRewriteContext context) | |||
| loadedModel.set(model); | |||
|
|
|||
| boolean isLicensed = MachineLearningField.ML_API_FEATURE.check(licenseState) | |||
| || featureCheckForMode(model.getLicenseLevel(), licenseState); | |||
| || model.getLicenseLevel() == License.OperationMode.BASIC; | |||
There was a problem hiding this comment.
Should the order wrt the ML check above be reversed? That way if it is basic we don't trigger tracking for ML use?
There was a problem hiding this comment.
@rjernst 100%, that makes sense as we wouldn't want to track platinum usage. I will make that change. Good catch.
…-previously-license-checks-for-models
…-previously-license-checks-for-models
benwtrent
added
the
auto-merge-without-approval
benwtrent
deleted the
feature/ml-fixing-previously-license-checks-for-models
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since trained models require either a platinum or basic license, our license checking can be
simplified.
Now, we check if ML APIs are allowed (platinum) or if the trained model is
basic.relates to: #79908