Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0] Revert "Return 200 OK response code for a cluster health timeout (#78968)" #80826

Merged

Conversation

arteam
Copy link
Contributor

@arteam arteam commented Nov 18, 2021

This reverts following PRs for 8.0

@arteam arteam changed the title [8.0] Revert "Return 200 OK response code for a cluster health timeout (#78968) Revert "[8.0] Return 200 OK response code for a cluster health timeout (#78968)" Nov 18, 2021
@arteam arteam changed the title Revert "[8.0] Return 200 OK response code for a cluster health timeout (#78968)" [8.0] Revert "Return 200 OK response code for a cluster health timeout (#78968)" Nov 18, 2021
@arteam arteam marked this pull request as draft November 18, 2021 12:33
@arteam arteam force-pushed the 8.0-revert-200-ok-response-code-cluster-health branch from f25767a to 3287dcb Compare November 18, 2021 12:43
@arteam arteam force-pushed the 8.0-revert-200-ok-response-code-cluster-health branch from 520be50 to faa79fe Compare November 18, 2021 13:32
@arteam arteam added >non-issue :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. labels Nov 18, 2021
@arteam arteam marked this pull request as ready for review November 18, 2021 15:58
@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Nov 18, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@arteam
Copy link
Contributor Author

arteam commented Nov 18, 2021

@elasticmachine update branch

Copy link
Contributor

@henningandersen henningandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should reenable bwc in this PR to ensure that it is reenabled when this PR is merged and also so that we are sure this ran with bwc enabled. Otherwise this looks good.

Copy link
Contributor

@henningandersen henningandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (if/when CI passes).

@arteam
Copy link
Contributor Author

arteam commented Nov 18, 2021

Thank you!

@arteam arteam merged commit d8b5bfe into elastic:8.0 Nov 18, 2021
@arteam arteam deleted the 8.0-revert-200-ok-response-code-cluster-health branch November 18, 2021 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. >non-issue Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v8.0.0-rc1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants