Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in gap_policy's default value for Serial differencing aggregation #80893

Merged
merged 2 commits into from
Nov 22, 2021
Merged

Fix typo in gap_policy's default value for Serial differencing aggregation #80893

merged 2 commits into from
Nov 22, 2021

Conversation

stchr
Copy link
Contributor

@stchr stchr commented Nov 20, 2021

See

elasticsearch/server/src/main/java/org/elasticsearch/search/aggregations/pipeline/BucketHelpers.java

Line 42 in bf57b74

* "insert_zeros": empty buckets will be filled with zeros for all metrics

@elasticsearchmachine elasticsearchmachine added v7.15.3 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Nov 20, 2021
@jrodewig jrodewig added the :Analytics/Aggregations Aggregations label Nov 22, 2021
@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Nov 22, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@jrodewig jrodewig added >docs General docs changes v7.16.1 v8.0.0-beta1 v8.1.0 and removed Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Nov 22, 2021
@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label Nov 22, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@jrodewig
Copy link
Contributor

@elasticmachine ok to test

jrodewig
jrodewig approved these changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @stchr.

imotov
imotov approved these changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@imotov imotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too. Might be a good idea to fix it in

elasticsearch/x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/aggs/MlAggsHelper.java

Line 33 in 12ad399

* The gap policy is always `INSERT_ZERO`
as well

@stchr stchr mentioned this pull request Nov 22, 2021
Merged
@jrodewig jrodewig merged commit 0c4c72e into elastic:7.15 Nov 22, 2021
This was referenced Nov 22, 2021
Merged
Merged
Merged
elasticsearchmachine pushed a commit that referenced this pull request Nov 22, 2021
@jrodewig @stchr
[DOCS] Fix typo in gap_policy's default value for serial differencing…
3589c4d 
… aggregation (#80893) (#80913)

Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>

Co-authored-by: Simon Stücher <stchr@users.noreply.github.com>
elasticsearchmachine pushed a commit that referenced this pull request Nov 22, 2021
@jrodewig @stchr
[DOCS] Fix typo in gap_policy's default value for serial differencing…
cf30b54 
… aggregation (#80893) (#80912)

Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>

Co-authored-by: Simon Stücher <stchr@users.noreply.github.com>
elasticsearchmachine pushed a commit that referenced this pull request Nov 22, 2021
@jrodewig @stchr
[DOCS] Fix typo in gap_policy's default value for serial differencing…
eaec0d7 
… aggregation (#80893) (#80914)

Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>

Co-authored-by: Simon Stücher <stchr@users.noreply.github.com>
ruflin pushed a commit to ruflin/Elastica that referenced this pull request Nov 23, 2021
@stchr
Extract setting gap policy to trait (#2023)
6b92d87 
The purpose of the introduced interface is to avoid typos by using constants for options.

That said, it also fixed the typo on Serial differencing aggregation, which is/was also a typo in the official docs. See elastic/elasticsearch#80893
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imotov imotov imotov approved these changes

@jrodewig jrodewig jrodewig approved these changes

Assignees
No one assigned
Labels
:Analytics/Aggregations Aggregations >docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Docs Meta label for docs team v7.15.3 v7.16.0 v8.0.0-beta1 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@stchr @elasticmachine @jrodewig @imotov @danhermann @elasticsearchmachine