Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] Add few additional MDP tests #81274

Merged
merged 3 commits into from
Dec 3, 2021
Merged

Conversation

grcevski
Copy link
Contributor

@grcevski grcevski commented Dec 2, 2021

This PR adds few more MDP tests where I found the higher level usage of the API might be missing some coverage.

It mostly focuses on PersistedClusterStateService and I made one of the ElasticsearchNodeCommand implementation tests use MDP by default instead of a single path, in order to exercise the underlying MDP functionality in ElasticsearchNodeCommand.

Relates to #78525

Nikola Grcevski added 2 commits December 2, 2021 14:30
Add more MDP tests for PersistedClusterStateService:
- Add MDP delete tests
- Add MDP tests for overriding lucene version.
This exercises the MDP support in NodeCommand
@grcevski grcevski added >test Issues or PRs that are addressing/adding tests :Core/Infra/Core Core issues without another label Team:Core/Infra Meta label for core/infra team v8.1.0 labels Dec 2, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

Copy link
Contributor

@ChrisHegarty ChrisHegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@grcevski grcevski merged commit eb782d2 into elastic:master Dec 3, 2021
@grcevski
Copy link
Contributor Author

grcevski commented Dec 3, 2021

Thanks Chris!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Core Core issues without another label Team:Core/Infra Meta label for core/infra team >test Issues or PRs that are addressing/adding tests v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants