Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate multifield mappings templates #81329

Merged

Conversation

jbaiera
Copy link
Member

@jbaiera jbaiera commented Dec 3, 2021

Using fields within fields in mappings is deprecated, but previously would not be listed in the deprecation API if the mapping was part of an index template, a component template, or within mapping dynamic_template sections which can be present in either of the locations. This change checks all six combinations of locations for the deprecated mapping structure.

relates #78445

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

Copy link
Member

@masseyke masseyke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the IndexDeprecationChecks method missing a test, it looks good to me.

@jbaiera jbaiera merged commit 48cbeda into elastic:7.16 Dec 8, 2021
@jbaiera jbaiera deleted the deprecate-multifield-mappings-templates branch December 8, 2021 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement Team:Data Management Meta label for data/management team v7.16.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants