-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose Japanese completion filter to kuromoji analysis plugin #81858
Merged
romseygeek
merged 4 commits into
elastic:master
from
mocobeta:expose-japanese-completion-filter
Jan 31, 2022
Merged
Expose Japanese completion filter to kuromoji analysis plugin #81858
romseygeek
merged 4 commits into
elastic:master
from
mocobeta:expose-japanese-completion-filter
Jan 31, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
v8.1.0
external-contributor
Pull request authored by a developer outside the Elasticsearch team
labels
Dec 17, 2021
I'd be happy if I could get your feedback. |
Pinging @elastic/es-search (Team:Search) |
@elasticmachine ok to test |
romseygeek
approved these changes
Jan 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mocobeta, this looks great! Assuming that CI is happy I am good to merge this.
@elasticmachine update branch |
Thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>enhancement
external-contributor
Pull request authored by a developer outside the Elasticsearch team
:Search Relevance/Analysis
How text is split into tokens
Team:Search
Meta label for search team
v8.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds analysis factories of JapaneseCompletionFilter and JapaneseCompletionAnalyzer (https://issues.apache.org/jira/browse/LUCENE-10102) to kuromoji plugin.
This is expected to be used in combination with Completion Suggester. For example:
Or, for searching use-cases, this could be used as a replacement of kuromoji_readingform; though we have not used it for searching.
gradle check
?