Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] Fix random RoleDescriptor compat with v6.7 #82242

Merged

Conversation

tvernum
Copy link
Contributor

@tvernum tvernum commented Jan 5, 2022

allowRestrictedIndices was only added in ES6.7 (see #37577).

For randomised testing we should not set that field if we are
generating a role descriptor that will be serialized into an older
version stream.

Resolves: #82216

allowRestrictedIndices was only added in ES6.7 (see elastic#37577).

For randomised testing we should not set that field if we are
generating a role descriptor that will be serialized into an older
version stream.

Resolves: elastic#82216
@tvernum tvernum added >test Issues or PRs that are addressing/adding tests :Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC auto-backport-and-merge v7.17.0 v7.16.3 labels Jan 5, 2022
Copy link
Contributor

@albertzaharovits albertzaharovits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvernum
Copy link
Contributor Author

tvernum commented Jan 10, 2022

@elasticmachine update branch

@tvernum tvernum added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Jan 10, 2022
@elasticsearchmachine elasticsearchmachine merged commit 0e14941 into elastic:7.17 Jan 10, 2022
tvernum added a commit to tvernum/elasticsearch that referenced this pull request Jan 10, 2022
allowRestrictedIndices was only added in ES6.7 (see elastic#37577). For
randomised testing we should not set that field if we are generating a
role descriptor that will be serialized into an older version stream.
Resolves: elastic#82216
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
7.16

elasticsearchmachine pushed a commit that referenced this pull request Jan 10, 2022
allowRestrictedIndices was only added in ES6.7 (see #37577). For
randomised testing we should not set that field if we are generating a
role descriptor that will be serialized into an older version stream.
Resolves: #82216
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC >test Issues or PRs that are addressing/adding tests v7.16.3 v7.17.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants