Remove unnecessary deprecation warning in Get Alias API #82773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check removed by this commit checks specifically for requests for aliases that *would* be system aliases, if they existed. I'm not sure why we were doing this, as we don't try to do this anywhere else. The only test that this seems to make fail is the test explicitly checking that behavior, which I don't think is really what we want. So I'm just removing it.
gwbrown
added
>non-issue
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
Failure is #82971. |
|
@elasticmachine update branch |
gwbrown
added
auto-backport-and-merge
auto-merge-without-approval
gwbrown
added a commit
to gwbrown/elasticsearch
that referenced
this pull request
Jan 25, 2022
The check removed by this commit checks specifically for requests for aliases that *would* be system aliases, if they existed. I'm not sure why we were doing this, as we don't try to do this anywhere else. The only test that this seems to make fail is the test explicitly checking that behavior, which I don't think is really what we want. So I'm just removing it. Relates elastic#81589
💔 Backport failed
You can use sqren/backport to manually backport by running |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 25, 2022
) The check removed by this commit checks specifically for requests for aliases that *would* be system aliases, if they existed. I'm not sure why we were doing this, as we don't try to do this anywhere else. The only test that this seems to make fail is the test explicitly checking that behavior, which I don't think is really what we want. So I'm just removing it. Relates #81589
gwbrown
added a commit
to gwbrown/elasticsearch
that referenced
this pull request
Jan 25, 2022
The check removed by this commit checks specifically for requests for aliases that *would* be system aliases, if they existed. I'm not sure why we were doing this, as we don't try to do this anywhere else. The only test that this seems to make fail is the test explicitly checking that behavior, which I don't think is really what we want. So I'm just removing it. Relates elastic#81589
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 25, 2022
) The check removed by this commit checks specifically for requests for aliases that *would* be system aliases, if they existed. I'm not sure why we were doing this, as we don't try to do this anywhere else. The only test that this seems to make fail is the test explicitly checking that behavior, which I don't think is really what we want. So I'm just removing it. Relates #81589
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check removed by this commit checks specifically for requests for aliases
that would be system aliases, if they existed. I'm not sure why we were doing
this, as we don't try to do this anywhere else. The only test that this seems to
make fail is the test explicitly checking that behavior, which I don't think is
really what we want. So I'm just removing it.
Relates #81589