Metadata of API key authentication must have roleDescriptor keys #84203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes conditional check for metadata keys related to API key role descriptors. API key authentication must always have these keys for it to work. The PR adds assertions for these keys and fixes relevant tests. Relates: elastic#82639
ywangd
added
>enhancement
:Security/Authentication
Collaborator
|
Pinging @elastic/es-security (Team:Security) |
Collaborator
|
Hi @ywangd, I've created a changelog YAML for you. |
Member
Author
|
@elasticmachine run elasticsearch-ci/full-bwc |
Member
Author
|
@elasticmachine update branch |
Collaborator
|
Hi @ywangd, I've created a changelog YAML for you. |
Member
Author
|
Label as |
Member
Author
|
@elasticmachine run elasticsearch-ci/full-bwc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes conditional check for metadata keys related to API key
role descriptors. API key authentication must always have these keys for
it to work. The PR adds assertions for these keys and fixes relevant
tests.
Relates: #82639