User Profile - Rename access to labels for request, response and mappings #85797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is agreed that the "access" field should be renamed to the more generic "labels". Data stored in this field are meant to be application specific (similar to "data" but searchable) and ES does not attempt to understand its content or purpose. Hence the more generic name is a better fit.
ywangd
added
>enhancement
:Security/Security
|
Pinging @elastic/clients-team (Team:Clients) |
|
Pinging @elastic/es-security (Team:Security) |
|
Hi @ywangd, I've created a changelog YAML for you. |
n1v0lg
approved these changes
Apr 12, 2022
x-pack/docs/en/rest-api/security/activate-user-profile.asciidoc
Outdated
Show resolved
Hide resolved
...security/src/main/java/org/elasticsearch/xpack/security/audit/logfile/LoggingAuditTrail.java
Outdated
Show resolved
Hide resolved
|
@elasticmachine run elasticsearch-ci/part-1-fips |
|
@elasticmachine update branch |
|
FIPS failure is this issue #85803 |
|
@elasticmachine run elasticsearch-ci/part-1 |
|
@elasticmachine update branch |
sethmlarson
approved these changes
Apr 13, 2022
ywangd
added a commit
to ywangd/elasticsearch
that referenced
this pull request
Apr 13, 2022
…ings (elastic#85797) It is agreed that the "access" field should be renamed to the more generic "labels". Data stored in this field are meant to be application specific (similar to "data" but searchable) and ES does not attempt to understand its content or purpose. Hence the more generic name is a better fit.
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 14, 2022
…ings (#85797) (#85883) It is agreed that the "access" field should be renamed to the more generic "labels". Data stored in this field are meant to be application specific (similar to "data" but searchable) and ES does not attempt to understand its content or purpose. Hence the more generic name is a better fit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is agreed that the "access" field should be renamed to the more
generic "labels". Data stored in this field are meant to be application
specific (similar to "data" but searchable) and ES does not attempt to
understand its content or purpose. Hence the more generic name is a
better fit.