Avoid starting test fixtures when resolving all external dependencies #86357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-vieira
added
>non-issue
:Delivery/Build
|
Pinging @elastic/es-delivery (Team:Delivery) |
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
May 11, 2022
💔 Backport failed
You can use sqren/backport to manually backport by running |
mark-vieira
added a commit
to mark-vieira/elasticsearch
that referenced
this pull request
May 11, 2022
…elastic#86357) # Conflicts: # plugins/repository-hdfs/build.gradle
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a few of our CI image builds failing due to
compseUptasks timing out. We really shouldn't be starting test fixtures when resolving dependencies. This just happened to be a case where a dependency is actually generated by the test fixture. Given these aren't "external" dependencies, it makes no sense to seed them into our CI images so I've ignored it here. There are likely loads of other instances of this, perhaps we should use some kind of convention when declaring these types of configurations so they are ignored.