Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master stability health indicator part 1 (when a master has been seen recently) #86524

Merged
Merged
Show file tree
Hide file tree
Changes from 30 commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
5198ff2
Initial commit for master stability health indicator (when a master h…
masseyke May 6, 2022
b477969
Update docs/changelog/86524.yaml
masseyke May 6, 2022
c97ff8d
reverting accidental change
masseyke May 6, 2022
75f5f78
Merge branch 'feature/health-api-master-stability-indicator' of githu…
masseyke May 6, 2022
08f0fee
Replacing InstanceHasMasterHealthIndicatorService
masseyke May 9, 2022
7156054
merging master
masseyke May 9, 2022
9ee8abe
Renamed includeDetails to explain, and fixed integration tests
masseyke May 9, 2022
80c2b00
cleaning up
masseyke May 10, 2022
ddb6983
cleanup
masseyke May 10, 2022
bfc6dde
cleanup
masseyke May 11, 2022
4a59bc8
chaning version on yaml test
masseyke May 11, 2022
20a9036
code review feedback
masseyke May 18, 2022
e5e647a
code review feedback
masseyke May 18, 2022
63e000e
Adding tests
masseyke May 18, 2022
f98f18c
Returning status of GREEN on null remote master history
masseyke May 19, 2022
1cf65b9
code review feedback, fixing unit tests
masseyke May 19, 2022
ef9fa8f
improving message in test
masseyke May 19, 2022
f3da89c
Adding integration tests
masseyke May 23, 2022
feea9e3
merging master
masseyke May 23, 2022
24ed95a
Adding getHelpURL()
masseyke May 23, 2022
2501a07
merging master
masseyke May 24, 2022
28315b3
fixing a bad merge
masseyke May 24, 2022
3c33673
Adding custom HealthIndicatorDetails for master stability
masseyke May 24, 2022
49a73c3
merging master
masseyke May 25, 2022
be3c0ef
fixing bad merge
masseyke May 25, 2022
7e65738
Merge branch 'master' into feature/health-api-master-stability-indicator
masseyke May 25, 2022
f0b9f68
fixing merge after 8.3.0 release
masseyke May 25, 2022
738a168
fixing merge after 8.3.0 release
masseyke May 25, 2022
3a14aa7
removing accidental commit
masseyke May 25, 2022
0102cdd
Merge branch 'master' into feature/health-api-master-stability-indicator
masseyke May 31, 2022
07bb192
code review feedback
masseyke Jun 1, 2022
4611752
code review feedback
masseyke Jun 2, 2022
360af7b
fixing stability integration test
masseyke Jun 2, 2022
c3f8838
fixing stability of integration test
masseyke Jun 3, 2022
9d4706a
code review feedback
masseyke Jun 6, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/changelog/86524.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pr: 86524
summary: Master stability health indicator part 1 (when a master has been seen recently)
area: Health
type: feature
issues: []
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
---
"cluster health basic test":
- skip:
version: "- 8.2.99"
reason: "summary text was updated in 8.3.0"
version: "- 8.3.99"
reason: "health was only added in 8.2.0, and master_is_stable in 8.4.0"

- do:
_internal.health: {}

- is_true: cluster_name
- match: { status: "green" }
- match: { components.cluster_coordination.status: "green" }
- match: { components.cluster_coordination.indicators.instance_has_master.status: "green" }
- match: { components.cluster_coordination.indicators.instance_has_master.summary: "Health coordinating instance has an elected master node." }
- match: { components.cluster_coordination.indicators.master_is_stable.status: "green" }
- match: { components.cluster_coordination.indicators.master_is_stable.summary: "The cluster has a stable master node" }
Original file line number Diff line number Diff line change
@@ -1,18 +1,16 @@
---
"cluster health test drilling down into a component":
- skip:
version: "- 8.2.99"
reason: "health drilldown was only added in 8.3.0"
version: "- 8.3.99"
reason: "health drilldown was only added in 8.3.0, and master_is_stable in 8.4.0"

- do:
_internal.health:
component: cluster_coordination

- is_true: cluster_name
- match: { components.cluster_coordination.status: "green" }
- match: { components.cluster_coordination.indicators.instance_has_master.status: "green" }
- match: { components.cluster_coordination.indicators.instance_has_master.summary: "Health coordinating instance has an elected master node." }
- is_true: components.cluster_coordination.indicators.instance_has_master.details.coordinating_node.node_id
- is_true: components.cluster_coordination.indicators.instance_has_master.details.coordinating_node.name
- is_true: components.cluster_coordination.indicators.instance_has_master.details.master_node.node_id
- is_true: components.cluster_coordination.indicators.instance_has_master.details.master_node.name
- match: { components.cluster_coordination.indicators.master_is_stable.status: "green" }
- match: { components.cluster_coordination.indicators.master_is_stable.summary: "The cluster has a stable master node" }
- is_true: components.cluster_coordination.indicators.master_is_stable.details.current_master
- is_true: components.cluster_coordination.indicators.master_is_stable.details.recent_masters
Original file line number Diff line number Diff line change
@@ -1,18 +1,16 @@
---
"cluster health test drilling down into a component and a feature":
- skip:
version: "- 8.2.99"
reason: "health drilldown was only added in 8.3.0"
version: "- 8.3.99"
reason: "health drilldown was only added in 8.3.0, and master_is_stable in 8.4.0"

- do:
_internal.health:
component: cluster_coordination
feature: instance_has_master
feature: master_is_stable

- is_true: cluster_name
- match: { components.cluster_coordination.indicators.instance_has_master.status: "green" }
- match: { components.cluster_coordination.indicators.instance_has_master.summary: "Health coordinating instance has an elected master node." }
- is_true: components.cluster_coordination.indicators.instance_has_master.details.coordinating_node.node_id
- is_true: components.cluster_coordination.indicators.instance_has_master.details.coordinating_node.name
- is_true: components.cluster_coordination.indicators.instance_has_master.details.master_node.node_id
- is_true: components.cluster_coordination.indicators.instance_has_master.details.master_node.name
- match: { components.cluster_coordination.indicators.master_is_stable.status: "green" }
- match: { components.cluster_coordination.indicators.master_is_stable.summary: "The cluster has a stable master node" }
- is_true: components.cluster_coordination.indicators.master_is_stable.details.current_master
- is_true: components.cluster_coordination.indicators.master_is_stable.details.recent_masters

This file was deleted.

Loading