TSDB: Initial reindex fix #86647
Merged
TSDB: Initial reindex fix #86647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that there is a fairly simple recipe for reindexing to a `time_series` index: 1. If you are reindexing from a time series index to a time series index and *not* changing the `@timestamp` or dimensions it "just works"(TM). 2. If you are reindexing from a standard index with a standard random `_id` you should clear it on reindex. 3. If you are reindexing from tsdb index to a tsdb index and modifying a dimension or `@timestamp` then you should clear the `_id`. This is not pleasant to have to remember. But it doesn't crash!
nik9000
added
>feature
:Distributed Indexing/Reindex
elasticmachine
added
Team:Analytics
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
Hi @nik9000, I've created a changelog YAML for you. |
|
Pinging @elastic/clients-team (Team:Clients) |
This teaches reindex the smallest thing that it needs to know about tsdb: `_id` is automatically generated. Armed with that knowledge reindex now doesn't attempt to copy the `_id` when writing to a tsdb index. Important: If the index doesn't yet exist it will *assume* that the index will be created in `standard` mode. We can detect what mode it *should* be created with in a follow up change.
nik9000
removed
the
:Distributed Indexing/Reindex
elasticmachine
removed
the
Team:Distributed (Obsolete)
martijnvg
approved these changes
May 11, 2022
| @@ -285,7 +300,7 @@ protected RequestWrapper<IndexRequest> buildRequest(ScrollableHitSource.Hit doc) | |||
| } | |||
|
|
|||
| // id and source always come from the found doc. Scripts can change them but they operate on the index request. | |||
| index.id(doc.getId()); | |||
| index.id(destinationIndexIdMapper.reindexId(doc.getId())); | |||
There was a problem hiding this comment.
this will probably also speed reindex up
There was a problem hiding this comment.
I don't think so. It's a noop for standard indices. For tsdb indices it saves us some bits on the wire and a comparison. We still have to regenerate the id.
docs/changelog/86647.yaml
Outdated
| @@ -0,0 +1,5 @@ | |||
| pr: 86647 | |||
There was a problem hiding this comment.
Should this be mentioned here? I don't think this changes anything with the tsdb feature flag in place? If so then we should label this PR also as non-issue.
There was a problem hiding this comment.
Silly generated thing....
|
run elasticsearch-ci/packaging-tests-windows-sample |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This teaches reindex the smallest thing that it needs to know about
tsdb:
_idis automatically generated. Armed with that knowledgereindex now doesn't attempt to copy the
_idwhen writing to a tsdbindex.
Important: If the index doesn't yet exist it will assume that the
index will be created in
standardmode. We can detect what mode itshould be created with in a follow up change.