Adjust osprobe assertion for burst cpu #86990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When gathering v1 cgroup cpu stats, the file is expected to have 3 lines. However, if the burst feature of cpu accounting is enabled, it will actually have 5 lines. This commit adjusts the assertion to allow for the extra lines. We ignore these lines already in the parsing of the calling method. Unfortunately this is not currently easy to test, and no tests exist. Give it is just an assertion that is relaxing, I think it's ok to fix this issue, and separately work on revamping the OsProbe tests.
rjernst
added
>bug
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
Hi @rjernst, I've created a changelog YAML for you. |
|
thanks a lot for addressing this, it will definitely make my life easier :) |
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
May 20, 2022
When gathering v1 cgroup cpu stats, the file is expected to have 3 lines. However, if the burst feature of cpu accounting is enabled, it will actually have 5 lines. This commit adjusts the assertion to allow for the extra lines. We ignore these lines already in the parsing of the calling method. Unfortunately this is not currently easy to test, and no tests exist. Give it is just an assertion that is relaxing, I think it's ok to fix this issue, and separately work on revamping the OsProbe tests.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
May 20, 2022
When gathering v1 cgroup cpu stats, the file is expected to have 3 lines. However, if the burst feature of cpu accounting is enabled, it will actually have 5 lines. This commit adjusts the assertion to allow for the extra lines. We ignore these lines already in the parsing of the calling method. Unfortunately this is not currently easy to test, and no tests exist. Give it is just an assertion that is relaxing, I think it's ok to fix this issue, and separately work on revamping the OsProbe tests.
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 20, 2022
When gathering v1 cgroup cpu stats, the file is expected to have 3 lines. However, if the burst feature of cpu accounting is enabled, it will actually have 5 lines. This commit adjusts the assertion to allow for the extra lines. We ignore these lines already in the parsing of the calling method. Unfortunately this is not currently easy to test, and no tests exist. Give it is just an assertion that is relaxing, I think it's ok to fix this issue, and separately work on revamping the OsProbe tests.
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 23, 2022
When gathering v1 cgroup cpu stats, the file is expected to have 3 lines. However, if the burst feature of cpu accounting is enabled, it will actually have 5 lines. This commit adjusts the assertion to allow for the extra lines. We ignore these lines already in the parsing of the calling method. Unfortunately this is not currently easy to test, and no tests exist. Give it is just an assertion that is relaxing, I think it's ok to fix this issue, and separately work on revamping the OsProbe tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When gathering v1 cgroup cpu stats, the file is expected to have 3
lines. However, if the burst feature of cpu accounting is enabled, it
will actually have 5 lines. This commit adjusts the assertion to allow
for the extra lines. We ignore these lines already in the parsing of the
calling method. Unfortunately this is not currently easy to test, and no
tests exist. Give it is just an assertion that is relaxing, I think it's
ok to fix this issue, and separately work on revamping the OsProbe
tests.