Add force_synthetic_source to GET #87536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the option to force synthetic source to the GET API. See elastic#87068 for more discussion on why you'd want to do that - the short version is to get an upper bound on the performance cost of using synthetic source in GET.
elasticmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
|
Pinging @elastic/clients-team (Team:Clients) |
romseygeek
approved these changes
Jun 9, 2022
| @@ -116,7 +116,8 @@ protected GetResponse shardOperation(GetRequest request, ShardId shardId) throws | |||
| request.realtime(), | |||
| request.version(), | |||
| request.versionType(), | |||
| request.fetchSourceContext() | |||
| request.fetchSourceContext(), | |||
| request.isForceSyntheticSource() | |||
There was a problem hiding this comment.
This was making me think that maybe we should add forceSynthetic as a member on FetchSourceContext, but it looks as though that is used in loads of other places so it would end up being a much bigger change.
There was a problem hiding this comment.
Yeah. I thought about it and didn't like.
| item.version(), | ||
| item.versionType(), | ||
| item.fetchSourceContext(), | ||
| false |
There was a problem hiding this comment.
This will be enabled in a follow-up, right?
There was a problem hiding this comment.
It'll be request.isForceSyntheticSource() I think.
javanna
added
the
:Distributed Indexing/CRUD
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the option to force synthetic source to the GET API. See
#87068 for more discussion on why you'd want to do that - the short
version is to get an upper bound on the performance cost of using
synthetic source in GET.