Skip to content

Conversation

@rjernst
Copy link
Member

@rjernst rjernst commented Dec 8, 2014

This is a start to exposing memory stats improvements from Lucene 5.0.
This adds the following categories of Lucene index pieces to index stats:

  • Terms
  • Stored fields
  • Term Vectors
  • Norms
  • Doc values

@rmuir
Copy link
Contributor

rmuir commented Dec 8, 2014

looks good, thank you!

@rjernst rjernst added v2.0.0-beta1 :Data Management/Stats Statistics tracking and retrieval APIs >enhancement labels Dec 8, 2014
@kimchy
Copy link
Member

kimchy commented Dec 8, 2014

LGTM, wonderful!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have a unittest for this in InternalEngineTest maybe?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@s1monw yes I will add in a follow up commit

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@s1monw Added a test in 0c8f5ac

This is a start to exposing memory stats improvements from Lucene 5.0.
This adds the following categories of Lucene index pieces to index stats:
* Terms
* Stored fields
* Term Vectors
* Norms
* Doc values
@rjernst rjernst merged commit fde32cc into elastic:master Dec 8, 2014
@rjernst rjernst deleted the pr/mem-stats branch January 21, 2015 23:22
@clintongormley clintongormley changed the title Stats: Add more fine grained memory stats from Lucene segment reader. Add more fine grained memory stats from Lucene segment reader to index stats Jun 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Data Management/Stats Statistics tracking and retrieval APIs >enhancement v2.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants