Skip to content

Fix log expectation inconsistency in flush test #89571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kingherc merged 1 commit into from
Aug 25, 2022
Merged

Fix log expectation inconsistency in flush test #89571

kingherc merged 1 commit into from
Aug 25, 2022

Conversation

@kingherc
Copy link
Contributor

@kingherc kingherc commented Aug 24, 2022

Fixes #89518

@elasticsearchmachine elasticsearchmachine added v8.5.0 needs:triage Requires assignment of a team area label labels Aug 24, 2022
@kingherc kingherc added >test-failure Triaged test failures from CI :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. labels Aug 24, 2022
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Aug 24, 2022

Pinging @elastic/es-distributed (Team:Distributed)

@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Aug 24, 2022
@kingherc kingherc requested a review from fcofdez August 24, 2022 10:07
fcofdez
fcofdez approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@fcofdez fcofdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left a small nit about the comment.

@kingherc kingherc merged commit 8cac490 into elastic:main Aug 25, 2022
@kingherc kingherc deleted the test-failure/89518-fix-new-flush-idle-test branch August 25, 2022 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fcofdez fcofdez fcofdez approved these changes

Assignees

No one assigned

Labels

:Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >test-failure Triaged test failures from CI v8.5.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CI] IndexShardTests testFlushOnIdleConcurrentFlushDoesNotWait failing

3 participants

@kingherc @elasticsearchmachine @fcofdez