Add optional left/right parameter to GeoJSON #8978
Conversation
nknize
added
:Analytics/Geo
There was a problem hiding this comment.
vertex ordering TO comply
|
I can just comment on the intent (LGTM) and the docs (minor comments left) but you'll need to find somebody else to review the code :) |
There was a problem hiding this comment.
What is "index" here? Should this be "field" or "shape" or "coordinates"?
There was a problem hiding this comment.
Good catch! Is this any clearer: "This will define vertex order for the coordinate list on the mapped geo_shape field"?
|
@nknize I left some comments. |
|
Good comments Ryan! Really appreciate it. I made some updates based on your feedback. Ready for another review! |
|
I'm confused why |
|
Good point Ryan. We can used the java doc for the enum values to describe On Monday, 22 December 2014, Ryan Ernst notifications@github.com wrote:
|
PR #8978 included 4 unnecessary enumeration values ('cw', 'clockwise', 'ccw', 'counterclockwise'). Since the ShapeBuilder.parse method handles these as strings and maps them to LEFT and RIGHT enumerators, respectively, their enumeration counterpart is unnecessary. This minor change adds 4 static convenience variables (COUNTER_CLOCKWISE, CLOCKWISE, CCW, CW) for purposes of the API and removes the unnecessary values from the Orientation Enum. closes #9035
PR #8978 included 4 unnecessary enumeration values ('cw', 'clockwise', 'ccw', 'counterclockwise'). Since the ShapeBuilder.parse method handles these as strings and maps them to LEFT and RIGHT enumerators, respectively, their enumeration counterpart is unnecessary. This minor change adds 4 static convenience variables (COUNTER_CLOCKWISE, CLOCKWISE, CCW, CW) for purposes of the API and removes the unnecessary values from the Orientation Enum. closes #9035
PR #8978 included 4 unnecessary enumeration values ('cw', 'clockwise', 'ccw', 'counterclockwise'). Since the ShapeBuilder.parse method handles these as strings and maps them to LEFT and RIGHT enumerators, respectively, their enumeration counterpart is unnecessary. This minor change adds 4 static convenience variables (COUNTER_CLOCKWISE, CLOCKWISE, CCW, CW) for purposes of the API and removes the unnecessary values from the Orientation Enum. closes #9035
|
merged from 77a7ef2 |
nknize
added
v2.0.0-beta1
:Analytics/Geo
clintongormley
changed the title
clintongormley
changed the title
PR elastic#8978 included 4 unnecessary enumeration values ('cw', 'clockwise', 'ccw', 'counterclockwise'). Since the ShapeBuilder.parse method handles these as strings and maps them to LEFT and RIGHT enumerators, respectively, their enumeration counterpart is unnecessary. This minor change adds 4 static convenience variables (COUNTER_CLOCKWISE, CLOCKWISE, CCW, CW) for purposes of the API and removes the unnecessary values from the Orientation Enum. closes elastic#9035
4 participants
This feature adds an optional orientation parameter to the GeoJSON document and geo_shape mapping enabling users to explicitly define how they want Elasticsearch to interpret vertex ordering. The default uses the right-hand rule (counterclockwise for outer ring, clockwise for inner ring) complying with OGC Simple Feature Access standards. The parameter can be explicitly specified for an entire index using the geo_shape mapping by adding "orientation":{"left"|"right"|"cw"|"ccw"|"clockwise"|"counterclockwise"} and/or overridden on each insert by adding the same parameter to the GeoJSON document.
closes #8764