-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make hostname resolution for loopback address more robust. #89788
Merged
slobodanadamovic
merged 1 commit into
elastic:main
from
slobodanadamovic:sa-improve-loopback-address-hostname-resolution
Sep 8, 2022
Merged
Make hostname resolution for loopback address more robust. #89788
slobodanadamovic
merged 1 commit into
elastic:main
from
slobodanadamovic:sa-improve-loopback-address-hostname-resolution
Sep 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented a fall-back to `localhost` when FQDN for loopback address (`127.0.0.1`) cannot be resolved. This can happen if test platform's DNS resolution is not properly configured.
slobodanadamovic
added
>test
Issues or PRs that are addressing/adding tests
:Security/Authentication
Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc)
Team:Security
Meta label for security team
auto-backport-and-merge
v8.5.0
v7.17.7
v8.4.2
labels
Sep 2, 2022
Pinging @elastic/es-security (Team:Security) |
This was referenced Sep 2, 2022
jakelandis
reviewed
Sep 6, 2022
...aRestTest/java/org/elasticsearch/xpack/security/authc/kerberos/KerberosAuthenticationIT.java
Show resolved
Hide resolved
jakelandis
approved these changes
Sep 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
slobodanadamovic
deleted the
sa-improve-loopback-address-hostname-resolution
branch
September 8, 2022 06:48
This was referenced Sep 8, 2022
slobodanadamovic
added a commit
to slobodanadamovic/elasticsearch
that referenced
this pull request
Sep 8, 2022
…9788) Implemented a fall-back to `localhost` when FQDN for loopback address (`127.0.0.1`) cannot be resolved. This can happen if test platform's DNS resolution is not properly configured. Closes elastic#89324
slobodanadamovic
added a commit
to slobodanadamovic/elasticsearch
that referenced
this pull request
Sep 8, 2022
…9788) Implemented a fall-back to `localhost` when FQDN for loopback address (`127.0.0.1`) cannot be resolved. This can happen if test platform's DNS resolution is not properly configured. Closes elastic#89324
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 8, 2022
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Security/Authentication
Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc)
Team:Security
Meta label for security team
>test
Issues or PRs that are addressing/adding tests
v7.17.7
v8.4.2
v8.5.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a fall-back to
localhost
when FQDN forloopback address (
127.0.0.1
) cannot be resolved.This can happen if test platform's DNS resolution
is not properly configured.
Closes #89324