SQL: Review unsigned long tests failing due to H2 lower precision #89800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luigidellaquila
added
>test
Collaborator
|
Pinging @elastic/es-ql (Team:QL) |
elasticsearchmachine
added
the
Team:QL (Deprecated)
luigidellaquila
assigned
astefan,
Luegg and
bpintea and unassigned
costin,
astefan,
Luegg and
bpintea
costin
approved these changes
Sep 7, 2022
Member
costin
left a comment
costin
left a comment
There was a problem hiding this comment.
LGTM.
I wonder if our tests have enough casting/downcasting and how corner cases are handled:
E.g.CAST(18446744073709551614/7306) AS UNSIGNED LONG, etc...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #83516
H2 is not as precise as Elasticsearch at calculating division and modulo operations on big numbers (numbers that exceed Long.MAX_VALUE). This leads to sporadic failures on sql-spec tests.
As stated in the issue (and verified with further analysis), all the failure logs report an incorrect expected value (calculated by H2), while the value returned by Elasticsearch proved to be correct.
This PR removes these tests from
sql-spec. These cases are covered incsv-specanyway.Also adding some further
csv-spectests on division (eg. unsigned long divided by floating point) for a complete coverage.