Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.4] Fix memory leak when double invoking RestChannel.sendResponse (#89873) #89881

Merged
merged 1 commit into from
Sep 7, 2022
Merged

[8.4] Fix memory leak when double invoking RestChannel.sendResponse (#89873) #89881

merged 1 commit into from
Sep 7, 2022

Conversation

original-brownbear
Copy link
Member

Backports the following commits to 8.4:

@original-brownbear
Fix memory leak when double invoking RestChannel.sendResponse (elasti…
96ce0c9 
…c#89873)

When using the resource handling channel we must make sure that
if we (by what is IMO a bug) try to double invoke it after
having already sent a response (or tried to do so) we at least
release the memory in the channel's outbound buffer.
Otherwise we will leak any memory from it that was used to create
the now failing to send `RestResponse`.
@original-brownbear original-brownbear added :Distributed Coordination/Network Http and internode communication implementations >bug auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. labels Sep 7, 2022
@elasticsearchmachine elasticsearchmachine mentioned this pull request Sep 7, 2022
Merged
@elasticsearchmachine elasticsearchmachine merged commit 3665655 into elastic:8.4 Sep 7, 2022
@original-brownbear original-brownbear deleted the backport/8.4/pr-89873 branch September 7, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport >bug :Distributed Coordination/Network Http and internode communication implementations Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v8.4.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@original-brownbear @elasticsearchmachine