Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Add ssl.verification_mode to secure settings #89981

Closed
wants to merge 5 commits into from
Closed

[DOCS] Add ssl.verification_mode to secure settings #89981

wants to merge 5 commits into from

Conversation

lockewritesdocs
Copy link
Contributor

@lockewritesdocs lockewritesdocs commented Sep 9, 2022 •
edited
Loading

Adds documentation for the xpack.security.http.ssl.verification_mode setting in the secure settings page, and removes this setting from the docker-compose.yml file in the Docker installation guide.

Closes #85375

@lockewritesdocs lockewritesdocs self-assigned this Sep 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2022

Documentation preview:

@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v8.5.0 labels Sep 9, 2022
@lockewritesdocs lockewritesdocs added >docs General docs changes :Security/TLS SSL/TLS, Certificates auto-backport-and-merge v8.3.4 v8.4.2 and removed needs:triage Requires assignment of a team area label labels Sep 9, 2022
@elasticsearchmachine elasticsearchmachine added Team:Docs Meta label for docs team Team:Security Meta label for security team labels Sep 9, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

@lockewritesdocs lockewritesdocs changed the title [DOCS] Add ssl.verification_mode to secure settings [DOCS] Add ssl.verification_mode to secure settings Sep 9, 2022
ywangd
ywangd reviewed Sep 12, 2022
View reviewed changes
Copy link
Member

@ywangd ywangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have comments about how we consolidate existing contents.

@lockewritesdocs
Copy link
Contributor Author

@ywangd, I updated the existing definition for verification_mode so that it can be used consistently throughout the TLS/SSL pages. This is a much cleaner implementation, so thanks for pointing out the existing block so that we can improve reuse and have cleaner source code ✋ 5️⃣ Please re-review when you can.

ywangd
ywangd reviewed Sep 13, 2022
View reviewed changes
Copy link
Member

@ywangd ywangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question about the new server variable.

@kingherc kingherc added v8.4.3 and removed v8.4.2 labels Sep 15, 2022
ywangd
ywangd approved these changes Sep 19, 2022
View reviewed changes
Copy link
Member

@ywangd ywangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csoulios csoulios removed the v8.5.0 label Sep 21, 2022
@kingherc kingherc added v8.7.0 and removed v8.6.0 labels Nov 16, 2022
@abdonpijpelink @tvernum
Update docs/reference/settings/ssl-settings.asciidoc
e480520 
Co-authored-by: Tim Vernum <tim@adjective.org>
@cla-checker-service
Copy link

❌ Author of the following commits did not sign a Contributor Agreement:
817c8d7, 716d21e, 73c4f02

Please, read and sign the above mentioned agreement if you want to contribute to this project

@abdonpijpelink abdonpijpelink mentioned this pull request Jan 19, 2023
Merged
@abdonpijpelink
Copy link
Contributor

Closing unmerged in favor of #93083.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvernum tvernum tvernum left review comments

@abdonpijpelink abdonpijpelink abdonpijpelink left review comments

@ywangd ywangd ywangd approved these changes

Assignees

@abdonpijpelink abdonpijpelink

Labels
>docs General docs changes :Security/TLS SSL/TLS, Certificates Team:Docs Meta label for docs team Team:Security Meta label for security team v8.6.1 v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

xpack.security.http.ssl.verification_mode is missing from the docs
8 participants
@lockewritesdocs @elasticsearchmachine @abdonpijpelink @tvernum @ywangd @csoulios @slobodanadamovic @kingherc