[TSDB] Improve downsampling performance by using tsid ordinals #90088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The assoicated issue has been fixed
to track when tsid changed
csoulios
added
>non-issue
:StorageEngine/Rollup
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
romseygeek
reviewed
Sep 15, 2022
| @@ -477,7 +477,6 @@ public void onFailure(Exception e) { | |||
| assertBusy(() -> assertTrue("In progress rollup did not complete", rollupListener.success), 60, TimeUnit.SECONDS); | |||
| } | |||
|
|
|||
| @AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/88800") | |||
There was a problem hiding this comment.
Is this an unrelated unmuting? Looking at the source issue it seems to have already been fixed elsewhere.
There was a problem hiding this comment.
Yes, we have fixed this issue some time ago. I don't know why this was not muted.
I unmuted it in this PR rather than submitting a separate one for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies downsampling operation so that it uses global ordinal to track tsid changes
PR depends on the work done in #90035
Relates to #74660