Skip to content

Conversation

@sparrowt
Copy link
Contributor

@sparrowt sparrowt commented Oct 11, 2022

Specify which integration to choose in the PagerDuty UI (there isn't one called simply "API" any more).

Also add a note to help avoid the confusion stemming from the fact that the watcher attributes still have names which seem to match the PagerDuty Events API v1, despite the fact that Elastic is actually now using Events API v2 behind the scenes.

Closes #90799

Specify which PagerDuty integration to select (given there isn't one called simply "API" any more).

Also add a note to help avoid the confusion stemming from the fact that the watcher attributes
still have names which seem to match the PagerDuty Events API v1 despite the fact that Elastic
is actually now using v2 of that API.

For reference: a ticket which I replied to, with a classic example of such confusion:
elastic/kibana#63933 (comment)
@github-actions
Copy link
Contributor

Documentation preview:

@elasticsearchmachine elasticsearchmachine added v8.6.0 needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team labels Oct 11, 2022
@elasticsearchmachine elasticsearchmachine added Team:Docs Meta label for docs team and removed needs:triage Requires assignment of a team area label labels Oct 11, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@kingherc kingherc assigned kingherc and unassigned kingherc Oct 11, 2022
Copy link
Contributor

@kingherc kingherc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, have just one minor comment. It would also be nice if someone from the Data Management team reviews as well.

. Log in to http://pagerduty.com[pagerduty.com] as an account administrator.
. Go to **Configuration > Services** and select the PagerDuty service. The
service must use the API integration.
service must use the **Events API V2** integration.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to update the below screenshot as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point - to be honest I wonder if we should just remove both of the pagerduty UI screenshots on this page, given (a) they'll only go out of date again before long, and (b) they don't add that much really, the textual description should be sufficient.

I'll expand the written steps a bit to make sure it's super clear.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds good to me as well since the steps look straight forward.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fab, see latest commits (sorry for not doing it all in 1, I'm being lazy and doing this via the web UI given the machine I'm currently on)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll wait a couple of days before approving, just in case the Data Management team chips in their opinion.

@kingherc kingherc self-assigned this Oct 11, 2022
@benwtrent benwtrent added v7.17.8 and removed v7.17.7 labels Oct 13, 2022
Copy link
Contributor

@kingherc kingherc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I did not see any comments from the mentioned teams, so assuming this is fine to approve & merge.

@kingherc kingherc merged commit bd97e2b into elastic:main Oct 14, 2022
kingherc added a commit to kingherc/elasticsearch that referenced this pull request Oct 14, 2022
Add a note to help avoid the confusion stemming from the fact that the watcher attributes
still have names which seem to match the PagerDuty Events API v1 despite the fact that we are
actually now using v2 of that API.

Delete outdated screenshots

Co-authored-by: Iraklis Psaroudakis <kingherc@gmail.com>
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.5
7.17

kingherc added a commit to kingherc/elasticsearch that referenced this pull request Oct 14, 2022
Add a note to help avoid the confusion stemming from the fact that the watcher attributes
still have names which seem to match the PagerDuty Events API v1 despite the fact that we are
actually now using v2 of that API.

Delete outdated screenshots

Co-authored-by: Iraklis Psaroudakis <kingherc@gmail.com>
elasticsearchmachine pushed a commit that referenced this pull request Oct 14, 2022
Add a note to help avoid the confusion stemming from the fact that the watcher attributes
still have names which seem to match the PagerDuty Events API v1 despite the fact that we are
actually now using v2 of that API.

Delete outdated screenshots

Co-authored-by: Iraklis Psaroudakis <kingherc@gmail.com>

Co-authored-by: Tom Sparrow <793763+sparrowt@users.noreply.github.com>
elasticsearchmachine pushed a commit that referenced this pull request Oct 14, 2022
Add a note to help avoid the confusion stemming from the fact that the watcher attributes
still have names which seem to match the PagerDuty Events API v1 despite the fact that we are
actually now using v2 of that API.

Delete outdated screenshots

Co-authored-by: Iraklis Psaroudakis <kingherc@gmail.com>

Co-authored-by: Tom Sparrow <793763+sparrowt@users.noreply.github.com>
@csoulios csoulios added v8.5.0 and removed v8.5.1 labels Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Data Management/Watcher >docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team v7.17.8 v8.5.0 v8.6.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation for pagerduty watcher action needs updating re PagerDuty Events API v2

5 participants