Fix PrioritizedThrottledTaskRunnerTests #93446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests try and execute `maxThreads` concurrent tasks to ensure that the rest of the executor's queue has been processed, but due to elastic#93443 (and the executor's zero timeout) this sometimes doesn't work. This commit fixes the problem by making every thread a core thread so that they do not time out. Closes elastic#92910
DaveCTurner
added
>test
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
idegtiarenko
reviewed
Feb 2, 2023
| @@ -39,7 +39,7 @@ public class PrioritizedThrottledTaskRunnerTests extends ESTestCase { | |||
| public void setUp() throws Exception { | |||
| super.setUp(); | |||
| maxThreads = between(1, 10); | |||
| executor = EsExecutors.newScaling("test", 1, maxThreads, 0, TimeUnit.MILLISECONDS, false, threadFactory, threadContext); | |||
| executor = EsExecutors.newScaling("test", maxThreads, maxThreads, 0, TimeUnit.NANOSECONDS, false, threadFactory, threadContext); | |||
There was a problem hiding this comment.
idegtiarenko
approved these changes
Feb 2, 2023
DaveCTurner
deleted the
2023-02-02-PrioritizedThrottledTaskRunnerTests-executor-timeout
branch
mark-vieira
pushed a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Feb 2, 2023
These tests try and execute `maxThreads` concurrent tasks to ensure that the rest of the executor's queue has been processed, but due to elastic#93443 (and the executor's zero timeout) this sometimes doesn't work. This commit fixes the problem by making every thread a core thread so that they do not time out. Closes elastic#92910 Closes elastic#92747
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Feb 6, 2023
The same fix as in elastic#93446, which was missed in elastic#93436
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests try and execute
maxThreadsconcurrent tasks to ensure that the rest of the executor's queue has been processed, but due to #93443 (and the executor's zero timeout) this sometimes doesn't work. This commit fixes the problem by making every thread a core thread so that they do not time out.Closes #92910
Closes #92747