Use the remote address from thread context for rest request auditing #94959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
needs:triage
albertzaharovits
added
:Security/Audit
|
Pinging @elastic/es-security (Team:Security) |
albertzaharovits
deleted the
always-audit-remote-host-address-from-thread-context
branch
albertzaharovits
added a commit
to albertzaharovits/elasticsearch
that referenced
this pull request
Jun 9, 2023
…lastic#94959) In preparation for when the audit trail will not be able to use the request interface to extract the remote endpoint address of rest requests, this PR makes the LoggingAuditTrail to look into the thread context for the remote address, and the SecurityRestFilter to populate as such the thread context before invoking the authentication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for when the audit trail will not be able to use
the request interface to extract the remote endpoint address of rest requests,
this PR makes the
LoggingAuditTrailto look into the thread contextfor the remote address, and the
SecurityRestFilterto populate as suchthe thread context before invoking the authentication.