Better caching of parsers in DateProcessor
#95299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ZoneId and Locale are expensive to create -- they're better behind the cache rather than keying into it.
joegallo
added
:Data Management/Ingest Node
|
Pinging @elastic/es-data-management (Team:Data Management) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #92880, it introduced this caching, but actually we can do even better than that PR did.
The ZoneId and Locale are expensive to create -- they're better behind the cache rather than keying into it.
In the above screenshot,
DateProcessor.executeis taking 3.86% of the profile, andDateProcess.newLocaleis taking 0.53%, so better caching could give us a ~13% speedup on theDateProcessorin question. This caching would be faster for anyDateProcessors that have alocaleortimezoneconfigured.