Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test validation fails for unwrapped requests #95949

Merged
merged 2 commits into from
May 9, 2023
Merged

Test validation fails for unwrapped requests #95949

merged 2 commits into from
May 9, 2023

Conversation

albertzaharovits
Copy link
Contributor

@albertzaharovits albertzaharovits commented May 9, 2023 •
edited
Loading

In patological cases it might be possible that validation in
invoked on requests that are not primed correctly (wrapped
with HttpHeadersAuthenticatorUtils#wrapAsMessageWithAuthenticationContext)
during HTTP decoding. This test asserts that such
occurences are a case of 500 error.

@albertzaharovits albertzaharovits self-assigned this May 9, 2023
@albertzaharovits albertzaharovits changed the title Test unwrapped Test validation fails for unwrapped requests May 9, 2023
@albertzaharovits albertzaharovits added >test Issues or PRs that are addressing/adding tests :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) labels May 9, 2023
@albertzaharovits albertzaharovits marked this pull request as ready for review May 9, 2023 13:59
@elasticsearchmachine elasticsearchmachine added the Team:Security Meta label for security team label May 9, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

jakelandis
jakelandis approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@jakelandis jakelandis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@albertzaharovits albertzaharovits merged commit 7d09f61 into elastic:main May 9, 2023
@albertzaharovits albertzaharovits deleted the test-unwrapped branch May 9, 2023 15:45
albertzaharovits added a commit to albertzaharovits/elasticsearch that referenced this pull request Jun 19, 2023
@albertzaharovits
Test validation fails for unwrapped requests (elastic#95949)
f1daa20 
In patological cases it might be possible that validation in
invoked on requests that are not primed correctly (wrapped
with HttpHeadersAuthenticatorUtils#wrapAsMessageWithAuthenticationContext)
during HTTP decoding. This test asserts that such
occurences are a case of 500 error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakelandis jakelandis jakelandis approved these changes

Assignees

@albertzaharovits albertzaharovits

Labels
:Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) Team:Security Meta label for security team >test Issues or PRs that are addressing/adding tests v8.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@albertzaharovits @elasticsearchmachine @jakelandis