Handle failure in TransportUpdateAction#handleUpdateFailureWithRetry #97290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here `executor(request.getShardId())` may throw, but we're already handling a failure so we cannot simply let this exception bubble up. This commit adjusts things to catch the exception, using it to fail the listener. Closes elastic#97286
DaveCTurner
added
>bug
:Distributed Indexing/CRUD
|
Opened #97291 for an unrelated test failure; @elasticmachine please run elasticsearch-ci/part-1 |
…eFailureWithRetry-failure
elasticsearchmachine
added
the
Team:Distributed
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
Hi @DaveCTurner, I've created a changelog YAML for you. |
kingherc
approved these changes
Jul 3, 2023
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jul 3, 2023
…lastic#97290) Here executor(request.getShardId()) may throw, but we're already handling a failure so we cannot simply let this exception bubble up. This commit adjusts things to catch the exception, using it to fail the listener. Closes elastic#97286
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jul 3, 2023
…lastic#97290) Here executor(request.getShardId()) may throw, but we're already handling a failure so we cannot simply let this exception bubble up. This commit adjusts things to catch the exception, using it to fail the listener. Closes elastic#97286
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 3, 2023
…hRetry (#97290) (#97326) * Handle failure in TransportUpdateAction#handleUpdateFailureWithRetry (#97290) Here executor(request.getShardId()) may throw, but we're already handling a failure so we cannot simply let this exception bubble up. This commit adjusts things to catch the exception, using it to fail the listener. Closes #97286 * Fix --------- Co-authored-by: Iraklis Psaroudakis <kingherc@gmail.com>
DaveCTurner
deleted the
2023/06/30/TransportUpdateAction-handleUpdateFailureWithRetry-failure
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here
executor(request.getShardId())may throw, but we're alreadyhandling a failure so we cannot simply let this exception bubble up.
This commit adjusts things to catch the exception, using it to fail the
listener.
Closes #97286