Remove the ability to have custom per-field postings and doc values formats. #9741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @Override | ||
| public PostingsFormatProvider postingsFormatProvider() { | ||
| return this.completionPostingsFormatProvider; | ||
| public synchronized PostingsFormat postingsFormat(PostingsFormat in) { |
There was a problem hiding this comment.
good catch with the sync here!
|
LGTM |
| @@ -237,3 +237,15 @@ curl -XGET 'localhost:9200/index/type/_search' | |||
| } | |||
| --------------- | |||
|
|
|||
| === Codecs | |||
|
|
|||
| It is not possible to specify per-field postings and doc values formats in the | |||
There was a problem hiding this comment.
Say "no longer possible" instead of "not possible"? You might also be more explicit about what "old indices" means. Also, typo: tail -> fail
|
LGTM too! Just a couple minor doc comments. |
|
Also, can you regenerate one of the static bwc indexes with your changes to create-bwc-index.py? For now one should be fine (say 1.4.2 or 1.4.3). Eventually I hope to have a script that will regenerate all of them without so much manual labor. |
|
Pushed a new commit that addresses @rjernst 's comments. Will push soon. |
…values formats. This commit makes the `postings_format` and `doc_values_format` options of mappings illegal on 2.0 and ignored on 1.x (meaning that the default postings and doc values formats from the codec will be used in such a case). This removes a fair amount of code. Close elastic#8746 elastic#9741
jpountz
force-pushed
the
fix/remove_format_services
branch
from
3316c23 to
4708227
Compare
dadoonet
added a commit
to elastic/elasticsearch-mapper-attachments
that referenced
this pull request
Feb 19, 2015
clintongormley
changed the title
clintongormley
added
the
:Search Foundations/Mapping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes the
postings_formatanddoc_values_formatoptions ofmappings illegal on 2.0 and ignored on 1.x (meaning that the default postings
and doc values formats from the codec will be used in such a case).
This removes a fair amount of code.
Close #8746