Skip to content

Expose getLastCommittedSegmentInfos in Engine #97978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stu-elastic merged 11 commits into from
Jul 28, 2023
Merged

Expose getLastCommittedSegmentInfos in Engine #97978

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ef00188
Expose segment file sizes
stu-elastic Jul 25, 2023
2766e6b
getLastCommittedSegmentFileSizes(): List<SegmentFileSize> -> Map<Stri…
stu-elastic Jul 26, 2023
7f29b4b
Merge branch 'main' of github.com:elastic/elasticsearch into ix-segme…
stu-elastic Jul 26, 2023
a3a28ad
Add test
stu-elastic Jul 26, 2023
507732b
Map<String, Long> getLastCommittedSegmentFileSizes -> long getLastCom…
stu-elastic Jul 27, 2023
0869397
Return commitinfo list
stu-elastic Jul 27, 2023
e9fbcb4
Lazily load file size
stu-elastic Jul 27, 2023
9340658
remove getLastCommittedSegmentInfoList
stu-elastic Jul 27, 2023
710fa2f
spotless
stu-elastic Jul 27, 2023
d5074c6
Change visibility of Engine.getLastCommittedSegmentInfos() to public
stu-elastic Jul 27, 2023
37c3042
add line back to InternalEngineTests
stu-elastic Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server/src/main/java/org/elasticsearch/index/engine/Engine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ public final EngineConfig config() {
return engineConfig;
}

protected abstract SegmentInfos getLastCommittedSegmentInfos();
public abstract SegmentInfos getLastCommittedSegmentInfos();

public MergeStats getMergeStats() {
return new MergeStats();
Expand Down
2 changes: 1 addition & 1 deletion server/src/main/java/org/elasticsearch/index/engine/InternalEngine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2478,7 +2478,7 @@ protected boolean maybeFailEngine(String source, Exception e) {
}

@Override
protected SegmentInfos getLastCommittedSegmentInfos() {
public SegmentInfos getLastCommittedSegmentInfos() {
return lastCommittedSegmentInfos;
}

Expand Down
2 changes: 1 addition & 1 deletion server/src/main/java/org/elasticsearch/index/engine/ReadOnlyEngine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ protected ReferenceManager<ElasticsearchDirectoryReader> getReferenceManager(Sea
}

@Override
protected SegmentInfos getLastCommittedSegmentInfos() {
public SegmentInfos getLastCommittedSegmentInfos() {
return lastCommittedSegmentInfos;
}

Expand Down