More cleanup of TransportAddVotingConfigExclusionsActionTests #98356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than waiting for both cluster state updates, we should assert that the second update has executed, performing the reconfiguration, by the time the API returns.
DaveCTurner
added
>test
|
Pinging @elastic/es-distributed (Team:Distributed) |
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
DaveCTurner
deleted the
2023/08/10/TransportAddVotingConfigExclusionsActionTests-more-cleanup
branch
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Aug 17, 2023
The docs for this API say the following: > If the API fails, you can safely retry it. Only a successful response > guarantees that the node has been removed from the voting > configuration and will not be reinstated. Unfortunately this isn't true today: if the request adds no exclusions then we do not wait before responding. This commit makes the API wait until all exclusions are really applied. Backport of elastic#98386, plus the test changes from elastic#98146 and elastic#98356.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 17, 2023
The docs for this API say the following: > If the API fails, you can safely retry it. Only a successful response > guarantees that the node has been removed from the voting > configuration and will not be reinstated. Unfortunately this isn't true today: if the request adds no exclusions then we do not wait before responding. This commit makes the API wait until all exclusions are really applied. Backport of #98386, plus the test changes from #98146 and #98356.
csoulios
pushed a commit
to csoulios/elasticsearch
that referenced
this pull request
Aug 18, 2023
…c#98356) Rather than waiting for both cluster state updates, we should assert that the second update has executed, performing the reconfiguration, by the time the API returns.
DaveCTurner
restored the
2023/08/10/TransportAddVotingConfigExclusionsActionTests-more-cleanup
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than waiting for both cluster state updates, we should assert
that the second update has executed, performing the reconfiguration, by
the time the API returns.