Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assertion in testReturnsImmediatelyIfVoteAlreadyWithdrawn #98570

Conversation

DaveCTurner
Copy link
Contributor

This test is today asserting that the initial state has all the
expected exclusions, but it should be checking the final state.

Relates #98386

This test is today asserting that the _initial_ state has all the
expected exclusions, but it should be checking the _final_ state.

Relates elastic#98386
@DaveCTurner DaveCTurner added >test Issues or PRs that are addressing/adding tests :Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. v8.11.0 labels Aug 17, 2023
@elasticsearchmachine elasticsearchmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Aug 17, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

Copy link
Contributor

@arteam arteam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaveCTurner DaveCTurner added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Aug 18, 2023
@elasticsearchmachine elasticsearchmachine merged commit 25a36f9 into elastic:main Aug 18, 2023
@DaveCTurner DaveCTurner deleted the 2023/08/17/testReturnsImmediatelyIfVoteAlreadyWithdrawn branch August 18, 2023 07:18
csoulios pushed a commit to csoulios/elasticsearch that referenced this pull request Aug 18, 2023
…c#98570)

This test is today asserting that the _initial_ state has all the
expected exclusions, but it should be checking the _final_ state.

Relates elastic#98386
@DaveCTurner DaveCTurner restored the 2023/08/17/testReturnsImmediatelyIfVoteAlreadyWithdrawn branch June 17, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >test Issues or PRs that are addressing/adding tests v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants