Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kibana system index does not allow user templates to affect it #98696

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Kibana system index does not allow user templates to affect it #98696

merged 2 commits into from
Aug 23, 2023

Conversation

rudolf
Copy link
Contributor

@rudolf rudolf commented Aug 21, 2023

Fixes #98695

@rudolf rudolf added the Team:Core/Infra Meta label for core/infra team label Aug 21, 2023
@elasticsearchmachine elasticsearchmachine added v8.11.0 needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team and removed Team:Core/Infra Meta label for core/infra team labels Aug 21, 2023
@rudolf rudolf mentioned this pull request Aug 21, 2023
Closed
9 tasks
@gwbrown gwbrown added >non-issue :Core/Infra/Core Core issues without another label and removed needs:triage Requires assignment of a team area label labels Aug 22, 2023
@gwbrown gwbrown self-assigned this Aug 22, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Aug 22, 2023
@gwbrown gwbrown mentioned this pull request Aug 22, 2023
Open
gwbrown
gwbrown approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@gwbrown gwbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. I've opened #98754 to remove the associated infrastructure, as this was the last index descriptor using it.

@rudolf rudolf merged commit 2239321 into elastic:main Aug 23, 2023
@rudolf rudolf deleted the kibana-dont-allow-templates branch August 23, 2023 10:07
azasypkin added a commit that referenced this pull request Aug 25, 2023
@azasypkin
Revert "Kibana system index does not allow user templates to affect it (
2a5c532 
#98696)"

This reverts commit 2239321.
azasypkin added a commit that referenced this pull request Aug 25, 2023
@azasypkin
Revert "Kibana system index does not allow user templates to affect it (
77f3924 
#98696)" (#98888)

* Revert "Kibana system index does not allow user templates to affect it (#98696)"

This reverts commit 2239321.

* Update docs/changelog/98888.yaml
This was referenced Aug 27, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwbrown gwbrown gwbrown approved these changes

Assignees

@gwbrown gwbrown

Labels
:Core/Infra/Core Core issues without another label external-contributor Pull request authored by a developer outside the Elasticsearch team >non-issue Team:Core/Infra Meta label for core/infra team v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ignore user templates on Kibana system indices
3 participants
@rudolf @elasticsearchmachine @gwbrown