Set explicit file permissions in NoticeTask #99206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianseeders
added
>non-issue
:Delivery/Build
|
Pinging @elastic/es-delivery (Team:Delivery) |
mark-vieira
approved these changes
Sep 5, 2023
|
nice catch |
brianseeders
added
auto-backport
brianseeders
added a commit
to brianseeders/elasticsearch
that referenced
this pull request
Sep 6, 2023
(cherry picked from commit 0ec47aa)
brianseeders
added a commit
to brianseeders/elasticsearch
that referenced
this pull request
Sep 6, 2023
(cherry picked from commit 0ec47aa)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
brianseeders
added a commit
to brianseeders/elasticsearch
that referenced
this pull request
Sep 6, 2023
(cherry picked from commit 0ec47aa) # Conflicts: # distribution/build.gradle
brianseeders
added a commit
that referenced
this pull request
Sep 6, 2023
brianseeders
added a commit
that referenced
this pull request
Sep 6, 2023
brianseeders
added a commit
that referenced
this pull request
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #99153
This error is due to a build cache object that got populated with a
NOTICE.txtwith an unexpected set of permissions (664instead of644).A Buildkite agent for another project with a different
umaskgenerated aNOTICE.txtfile with different permissions. The other project shares a build cache withelasticsearch, and was recently allowed to populate the cache as well as read from it.Anywhere that we care enough to test permissions on files, we should set those permissions at file creation time, so that the files are correct regardless of what OS they get created on / etc. So, that's what I'm doing in this PR.