Compute cluster state chunk count in tests #99282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today in tests we hard-code the expected chunk count for cluster state responses, which means we have to change several magic numbers whenever anything about the serialization changes. This commit adjusts these tests to compute the expected chunk count based on the contents of the cluster state instead, which removes the need for those magic numbers.
DaveCTurner
added
>test
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
thecoop
reviewed
Sep 7, 2023
| } else { | ||
| // could be anything, we have to just try it | ||
| chunkCount += Iterables.size( | ||
| (Iterable<ToXContent>) (() -> Iterators.map(custom.toXContentChunked(params), Function.identity())) |
There was a problem hiding this comment.
Is the Iterators.map needed here?
There was a problem hiding this comment.
Yeah or at least I couldn't work out a nicer way to satisfy the typechecker that an Iterator<? extends ToXContent> is a cromulent Iterator<ToXContent>.
thecoop
approved these changes
Sep 7, 2023
|
This is great. I wasn't clear on chunk arithmetic when I was updating the magic numbers. Now I almost sort of get it. |
|
Yeah nor me I just hard-coded the numbers to make the tests pass in #92285, it's been bugging me ever since. |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 13, 2023
Compiling with `Werror` indicates these test files implicitly do a lossy conversion. Making the final conversion explicit in the tests. Relates: #99282
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today in tests we hard-code the expected chunk count for cluster state
responses, which means we have to change several magic numbers whenever
anything about the serialization changes. This commit adjusts these
tests to compute the expected chunk count based on the contents of the
cluster state instead, which removes the need for those magic numbers.