Small simplification to MockUtils #99398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaveCTurner
added
>non-issue
:Distributed Indexing/Distributed
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
Contributor
Author
|
Just a suggestion (didn't mention this in #99385 because I didn't want to hold things up on questions of style). |
| public void testActionNames() { | ||
| final ActionFilters actionFilters = mock(ActionFilters.class); | ||
| final TransportService transportService = mock(TransportService.class); | ||
| final TransportService transportService = MockUtils.setupTransportServiceWithThreadpoolExecutor(); |
Contributor
There was a problem hiding this comment.
I wonder if we want to keep MockUtils generic and put all common mocks set up there or is it better to have it TransportService specific? If so it could be renamed to TransportServiceMocks?
Contributor
Author
There was a problem hiding this comment.
I don't have any long-term plans for this, maybe we'll collect some other mock-related utils in here.
idegtiarenko
approved these changes
Sep 11, 2023
DiannaHohensee
approved these changes
Sep 11, 2023
Contributor
DiannaHohensee
left a comment
DiannaHohensee
left a comment
There was a problem hiding this comment.
Looks nice and concise, lgtm!
| final ActionFilters actionFilters = mock(ActionFilters.class); | ||
| final BigArrays bigArrays = mock(BigArrays.class); | ||
| final TransportService transportService = mock(TransportService.class); | ||
| final TransportService transportService = MockUtils.setupTransportServiceWithThreadpoolExecutor(); |
Contributor
There was a problem hiding this comment.
Thanks for the cleanup :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.