Use long in Centroid count #99491
Merged
Use long in Centroid count #99491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centroids currently use integers to track how many samples their mean tracks. This can overflow in case the digest tracks billions of samples or more. TDigestState already serializes the count as VLong, so it can be read as VInt without compatibility issues. Fixes elastic#80153
kkrik-es
added
>bug
:Analytics/Aggregations
|
Hi @kkrik-es, I've created a changelog YAML for you. |
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
|
@elasticsearchmachine run elasticsearch-ci/docs |
|
Should this also be backported to the 8.10 branch? |
kkrik-es
added
v8.10.1
auto-backport
💚 Backport successful
|
kkrik-es
added a commit
to kkrik-es/elasticsearch
that referenced
this pull request
Sep 13, 2023
* Use long in Centroid count Centroids currently use integers to track how many samples their mean tracks. This can overflow in case the digest tracks billions of samples or more. TDigestState already serializes the count as VLong, so it can be read as VInt without compatibility issues. Fixes elastic#80153 * Update docs/changelog/99491.yaml * More test fixes * Bump TransportVersion * Revert TransportVersion change
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 13, 2023
* Use long in Centroid count Centroids currently use integers to track how many samples their mean tracks. This can overflow in case the digest tracks billions of samples or more. TDigestState already serializes the count as VLong, so it can be read as VInt without compatibility issues. Fixes #80153 * Update docs/changelog/99491.yaml * More test fixes * Bump TransportVersion * Revert TransportVersion change
kkrik-es
added a commit
to kkrik-es/elasticsearch
that referenced
this pull request
Sep 26, 2023
Histograms currently use integers to store the count of each value, which can overflow. Switch to using long integers to avoid this. TDigestState was updated to use long for centroid value count in elastic#99491 Fixes elastic#99820
kkrik-es
added a commit
that referenced
this pull request
Sep 29, 2023
* Represent histogram value count as long Histograms currently use integers to store the count of each value, which can overflow. Switch to using long integers to avoid this. TDigestState was updated to use long for centroid value count in #99491 Fixes #99820 * Update docs/changelog/99912.yaml * spotless fix
piergm
pushed a commit
to piergm/elasticsearch
that referenced
this pull request
Oct 2, 2023
* Represent histogram value count as long Histograms currently use integers to store the count of each value, which can overflow. Switch to using long integers to avoid this. TDigestState was updated to use long for centroid value count in elastic#99491 Fixes elastic#99820 * Update docs/changelog/99912.yaml * spotless fix
jakelandis
pushed a commit
to jakelandis/elasticsearch
that referenced
this pull request
Oct 2, 2023
* Represent histogram value count as long Histograms currently use integers to store the count of each value, which can overflow. Switch to using long integers to avoid this. TDigestState was updated to use long for centroid value count in elastic#99491 Fixes elastic#99820 * Update docs/changelog/99912.yaml * spotless fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Centroids currently use integers to track how many samples their mean tracks. This can overflow in case the digest tracks billions of samples or more.
TDigestState already serializes the count as VLong, so it can be read as VLong instead of Vint without compatibility issues.
Fixes #80153