Add appName and appVersion parameters #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also deprecate the kbnVersion parameter
thomasneirynck
approved these changes
Mar 4, 2020
| @@ -104,11 +106,16 @@ export class EMSClient { | |||
| proxyPath, | |||
| }) { | |||
|
|
|||
| // Remove kbnVersion in 8.0 | |||
| if (kbnVersion) { | |||
| console.warn('The "kbnVersion" parameter for ems-client is deprecated. Please use "appVersion" instead.'); | |||
There was a problem hiding this comment.
thx. I guess we'll need corresponding Kibana update then as well?
There was a problem hiding this comment.
thx. I guess we'll need corresponding Kibana update then as well?
Yup. This will be part of the changes we need when we bump the ems-client dependency in Kibana and ems-landing-page for 7.7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17.
This PR adds an
appNameparameter to the constructor which updates themy_app_nameparameter in the query string in requests to EMS. Previously,my_app_namewas hardcoded to "kibana", but we should support additional clients such as ems-landing-page.appNamedefaults to "kibana" if not specified.This PR also adds a
appVersionparameter designed to replace thekbnVersionparameter in the constructor sincekbnVersionis a bit of a misnomer since ems-client supports additional clients besides Kibana. A deprecation warning is logged ifkbnVersionis specified. BothappVersionandkbnVersionapply themy_app_versionquery string parameter in requests to EMS. If not specified,appVersionfalls back to thekbnVersionparameter.