Upgrade to Node 20 #208
Merged
Upgrade to Node 20 #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbudz
commented
Nov 8, 2023
Co-authored-by: Jon <jon@budzenski.me>
Member
|
Buildkite test this |
Collaborator
💚 Build Succeeded
|
jsanz
approved these changes
Nov 9, 2023
Member
jsanz
left a comment
jsanz
left a comment
There was a problem hiding this comment.
Changes are OK to me, I'll also go ahead and merge this change so I can publish an update of the library in NPM today and open a PR in Kibana to fix this issue.
cc. @nickpeihl
jsanz
pushed a commit
to jsanz/ems-client
that referenced
this pull request
Nov 9, 2023
* Upgrade to Node 20 * Update package.json Co-authored-by: Jon <jon@budzenski.me> --------- Co-authored-by: Jorge Sanz <jorge@jorgesanz.net> (cherry picked from commit 2fa806f) # Conflicts: # .nvmrc # package.json
jsanz
pushed a commit
to jsanz/ems-client
that referenced
this pull request
Nov 9, 2023
* Upgrade to Node 20 * Update package.json Co-authored-by: Jon <jon@budzenski.me> --------- Co-authored-by: Jorge Sanz <jorge@jorgesanz.net> (cherry picked from commit 2fa806f) # Conflicts: # .nvmrc # package.json
Member
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
jsanz
added a commit
that referenced
this pull request
Nov 9, 2023
* Upgrade to Node 20 (#208) * Upgrade to Node 20 * Update package.json Co-authored-by: Jon <jon@budzenski.me> --------- Co-authored-by: Jorge Sanz <jorge@jorgesanz.net> (cherry picked from commit 2fa806f) # Conflicts: # .nvmrc # package.json * add .nvmrc file --------- Co-authored-by: Jon <jon@budzenski.me>
jsanz
added a commit
that referenced
this pull request
Nov 9, 2023
* Upgrade to Node 20 (#208) * Upgrade to Node 20 * Update package.json Co-authored-by: Jon <jon@budzenski.me> --------- Co-authored-by: Jorge Sanz <jorge@jorgesanz.net> (cherry picked from commit 2fa806f) # Conflicts: # .nvmrc # package.json * add .nvmrc file --------- Co-authored-by: Jon <jon@budzenski.me>
This was referenced Nov 9, 2023
jsanz
added a commit
to elastic/kibana
that referenced
this pull request
Nov 9, 2023
## Summary Related to elastic/ems-client#208 Update to a version of `ems-client` that supports Node 20. I'm creating new PRs for: * `@elastic/ems-client@8.4.1` in Kibana `8.11` branch * `@elastic/ems-client@7.17.1` for Kibana `7.17` branch Sorry for the small overhead on reviewing; this way, it seems faster to get CI running in parallel for the three releases and unblock the operations team on this issue.
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on https://github.com/elastic/ci-agent-images/pull/429
We're looking into upgrading Kibana to Node 20 but running into bootstrap issues: