Skip to content

Commit

Permalink
[EuiFlyout] - Fixed onClose invoked with unexpected parameter (#4505)
Browse files Browse the repository at this point in the history
* Fixed onClose invoking with unexpected parameter

* cl
  • Loading branch information
akashgp09 authored Feb 10, 2021
1 parent 5aab25a commit 4388422
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

**Bug fixes**

- Fixed `onClose` invoking with unexpected parameter in `EuiFlyout` ([#4505](https://github.com/elastic/eui/pull/4505))
- Fixed invalid color entry passed to `EuiBadge` color prop ([#4481](https://github.com/elastic/eui/pull/4481))
- Fixed `EuiCodeBlock` focus-state if content overflows ([#4463]https://github.com/elastic/eui/pull/4463)

Expand Down
4 changes: 3 additions & 1 deletion src/components/flyout/flyout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,9 @@ export const EuiFlyout: FunctionComponent<EuiFlyoutProps> = ({
iconType="cross"
color="text"
aria-label={closeButtonAriaLabel || closeAriaLabel}
onClick={onClose}
onClick={() => {
onClose();
}}
data-test-subj="euiFlyoutCloseButton"
/>
)}
Expand Down

0 comments on commit 4388422

Please sign in to comment.