[EuiFlyout] Fix broken push flyout behavior (#6764)

* Fix focus trap scroll locking when disabled

* Harden scrollLock behavior on EuiFlyout

- push flyouts should still never set scrollLock to true

* changelog

src/components/flyout/flyout.spec.tsx

@@ -62,6 +62,19 @@ describe('EuiFlyout', () => {
         'euiFlyoutCloseButton'
       );
     });
+
+    it('does not focus trap or scrollLock for push flyouts', () => {
+      cy.mount(
+        <>
+          <div style={{ height: 2000 }}>Body scroll</div>
+          <Flyout type="push" pushMinBreakpoint="xs" size="100px" />
+        </>
+      );
+
+      cy.get('body').realClick({ position: 'topLeft' }).realPress('End'); // TODO: Use cypress-real-event's `realMouseWheel` API, whenever they release it
+      cy.wait(500); // Wait a tick to let scroll position update
+      cy.window().its('scrollY').should('not.equal', 0);
+    });
   });
 
   describe('Close behavior: standard', () => {

src/components/flyout/flyout.tsx

@@ -405,7 +405,7 @@ export const EuiFlyout = forwardRef(
     let flyout = (
       <EuiFocusTrap
         disabled={isPushed}
-        scrollLock={ownFocus}
+        scrollLock={hasOverlayMask}
         clickOutsideDisables={!ownFocus}
         onClickOutside={onClickOutside}
         {...focusTrapProps}

src/components/focus_trap/focus_trap.spec.tsx

@@ -255,6 +255,19 @@ describe('EuiFocusTrap', () => {
       cy.window().its('scrollY').should('not.equal', 0);
     });
 
+    it('does not scrollLock if the focus trap is disabled', () => {
+      cy.realMount(
+        <div style={{ height: 2000 }}>
+          <EuiFocusTrap disabled={true} scrollLock={true}>
+            Test
+          </EuiFocusTrap>
+        </div>
+      );
+
+      scrollSelector('body');
+      cy.window().its('scrollY').should('not.equal', 0);
+    });
+
     it('prevents scrolling on the page body', () => {
       cy.realMount(
         <div style={{ height: 2000 }}>

src/components/focus_trap/focus_trap.tsx

@@ -146,7 +146,7 @@ export class EuiFocusTrap extends Component<EuiFocusTrapProps, State> {
     return (
       <FocusOn {...focusOnProps}>
         {children}
-        {scrollLock && <RemoveScrollBar gapMode={gapMode} />}
+        {!isDisabled && scrollLock && <RemoveScrollBar gapMode={gapMode} />}
       </FocusOn>
     );
   }

upcoming_changelogs/6764.md

@@ -0,0 +1,3 @@
+**Bug fixes**
+
+- Fixed broken push `EuiFlyout` behavior