Skip to content

Commit

Permalink
[EuiDataGrid] Change data grid body background to light gray (#5562)
Browse files Browse the repository at this point in the history
* Show unrendered cells as gray when scrolling/not yet virtualized

* Misc cleanup - move toolbar related css to toolbar scss file

* Add changelog entry
  • Loading branch information
Constance authored Jan 31, 2022
1 parent 2e285e8 commit 7412e4f
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
## [`main`](https://github.com/elastic/eui/tree/main)

- Updated `EuiDataGrid`s with scrolling content to always have a border around the grid body and any scrollbars ([#5563](https://github.com/elastic/eui/pull/5563))
- Updated `EuiDataGrid`'s body to a light gray background, which primarily shows when scrolling through virtualized content ([#5562](https://github.com/elastic/eui/pull/5562))
- Added referenceable `id` for the generated label in `EuiFormRow` ([#5574](https://github.com/elastic/eui/pull/5574))
- Addeed optional attribute configurations in `EuiPopover` to aid screen reader announcements ([#5574](https://github.com/elastic/eui/pull/5574))
- Added `ref` passthroughs to `EuiIputPopover` subcomponents ([#5574](https://github.com/elastic/eui/pull/5574))
Expand Down
10 changes: 1 addition & 9 deletions src/components/datagrid/_data_grid.scss
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
overflow: hidden;
z-index: 1; // Sits below the controls above it and pagination below it
position: relative;
background: $euiColorEmptyShade;
background: $euiPageBackgroundColor;
font-feature-settings: 'tnum' 1; // Tabular numbers
}

Expand All @@ -51,14 +51,6 @@
}
}


.euiDataGrid__controlScroll {
@include euiYScrollWithShadows;
max-height: $euiDataGridPopoverMaxHeight;
padding: $euiSizeS;
margin: -$euiSizeS; // Offset against the panel to make the scrollbar flush scrollbars
}

.euiDataGrid__focusWrap {
height: 100%;
}
Expand Down
7 changes: 7 additions & 0 deletions src/components/datagrid/controls/_data_grid_toolbar.scss
Original file line number Diff line number Diff line change
Expand Up @@ -59,3 +59,10 @@
transition: none !important;
margin-top: -$euiSizeS;
}

.euiDataGrid__controlScroll {
@include euiYScrollWithShadows;
max-height: $euiDataGridPopoverMaxHeight;
padding: $euiSizeS;
margin: -$euiSizeS; // Offset against the panel to make the scrollbar flush scrollbars
}

0 comments on commit 7412e4f

Please sign in to comment.