Remove columnIndex from cellProps callback.

elastic · May 25, 2018 · 775a0c3 · 775a0c3
1 parent f4cbb87
commit 775a0c3
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 10 deletions.
diff --git a/src-docs/src/views/tables/basic/basic.js b/src-docs/src/views/tables/basic/basic.js
@@ -91,11 +91,12 @@ export const Table = () => {
     };
   };
 
-  const getCellProps = (item, column, columnIndex) => {
+  const getCellProps = (item, column) => {
     const { id } = item;
+    const { field } = column;
     return {
       className: 'customCellClass',
-      'data-test-subj': `cell-${id}-${columnIndex}`,
+      'data-test-subj': `cell-${id}-${field}`,
     };
   };
 

diff --git a/src/components/basic_table/__snapshots__/basic_table.test.js.snap b/src/components/basic_table/__snapshots__/basic_table.test.js.snap
@@ -28,7 +28,7 @@ exports[`EuiBasicTable cellProps renders cells with custom props from a callback
             <EuiTableRowCell
               align="left"
               className="customRowClass"
-              data-test-subj="cell-1-0-name"
+              data-test-subj="cell-1-name"
               header="Name"
               key="_data_column_name_0_0"
               onClick={[Function]}
@@ -47,7 +47,7 @@ exports[`EuiBasicTable cellProps renders cells with custom props from a callback
             <EuiTableRowCell
               align="left"
               className="customRowClass"
-              data-test-subj="cell-2-0-name"
+              data-test-subj="cell-2-name"
               header="Name"
               key="_data_column_name_1_0"
               onClick={[Function]}
@@ -66,7 +66,7 @@ exports[`EuiBasicTable cellProps renders cells with custom props from a callback
             <EuiTableRowCell
               align="left"
               className="customRowClass"
-              data-test-subj="cell-3-0-name"
+              data-test-subj="cell-3-name"
               header="Name"
               key="_data_column_name_2_0"
               onClick={[Function]}

diff --git a/src/components/basic_table/basic_table.js b/src/components/basic_table/basic_table.js
@@ -169,10 +169,10 @@ function getRowProps(item, rowProps) {
   return {};
 }
 
-function getCellProps(item, column, columnIndex, cellProps) {
+function getCellProps(item, column, cellProps) {
   if (cellProps) {
     if (isFunction(cellProps)) {
-      return cellProps(item, column, columnIndex);
+      return cellProps(item, column);
     }
     return cellProps;
   }
@@ -681,7 +681,7 @@ export class EuiBasicTable extends Component {
     const content = contentRenderer(value, item);
 
     const { cellProps: cellPropsCallback } = this.props;
-    const cellProps = getCellProps(item, column, columnIndex, cellPropsCallback);
+    const cellProps = getCellProps(item, column, cellPropsCallback);
 
     return (
       <EuiTableRowCell

diff --git a/src/components/basic_table/basic_table.test.js b/src/components/basic_table/basic_table.test.js
@@ -156,11 +156,11 @@ describe('EuiBasicTable', () => {
             description: 'description'
           }
         ],
-        cellProps: (item, column, columnIndex) => {
+        cellProps: (item, column) => {
           const { id } = item;
           const { field } = column;
           return {
-            'data-test-subj': `cell-${id}-${columnIndex}-${field}`,
+            'data-test-subj': `cell-${id}-${field}`,
             className: 'customRowClass',
             onClick: () => {},
           };