Skip to content

Commit

Permalink
[WIP][rtl][css] Fix button margins for RTL langs
Browse files Browse the repository at this point in the history
When showing a button in RTL, margin-left/right shows up
incorrectly. The needed CSS seems to be `margin-inline-start/end`.

Those values do not exist in IE, so not sure if we can introduce these or not just yet.
  • Loading branch information
nyurik committed Aug 29, 2020
1 parent 28d6371 commit 81a2a5b
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/global_styling/mixins/_button.scss
Original file line number Diff line number Diff line change
Expand Up @@ -72,16 +72,16 @@
flex-direction: row-reverse;

> * + * {
margin-left: 0; // 1, 2
margin-right: $euiSizeS; // 1, 2
margin-inline-start: 0; // 1, 2
margin-inline-end: $euiSizeS; // 1, 2
}
} @else {
display: flex;
justify-content: center;
align-items: center;

> * + * {
margin-left: $euiSizeS; // 1
margin-inline-start: $euiSizeS; // 1
}
}
}
Expand Down

0 comments on commit 81a2a5b

Please sign in to comment.