[EuiTreeView] JSX Typescript error (#7452)

elastic · Jan 9, 2024 · 87b7151 · 87b7151
1 parent e67ef5d
commit 87b7151
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/changelogs/upcoming/7452.md b/changelogs/upcoming/7452.md
@@ -0,0 +1,3 @@
+**Bug fixes**
+
+- Fixed an `EuiTreeView` JSX Typescript error
diff --git a/src/components/tree_view/tree_view.tsx b/src/components/tree_view/tree_view.tsx
@@ -31,7 +31,7 @@ function hasAriaLabel(
 
 function getTreeId(
   propId: string | undefined,
-  contextId: string,
+  contextId: string = '',
   idGenerator: Function
 ) {
   return propId ?? (contextId === '' ? idGenerator() : contextId);
@@ -123,8 +123,12 @@ export class EuiTreeView extends Component<EuiTreeViewProps, EuiTreeViewState> {
 
   constructor(
     props: EuiTreeViewProps,
-    context: ContextType<typeof EuiTreeViewContext>
+    // Without the optional ? typing, TS will throw errors on JSX component errors
+    // @see https://github.com/facebook/react/issues/13944#issuecomment-1183693239
+    context?: ContextType<typeof EuiTreeViewContext>
   ) {
+    // TODO: context in constructor has been deprecated.
+    // We should likely convert this to a function component
     super(props, context);
 
     this.isNested = !!this.context;
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
		Bug fixes

		- Fixed an `EuiTreeView` JSX Typescript error