Update default prop logic for heading

elastic · May 5, 2022 · 8cde1f1 · 8cde1f1
1 parent f209dd4
commit 8cde1f1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/src-docs/src/views/call_out/call_out_example.js b/src-docs/src/views/call_out/call_out_example.js
@@ -86,7 +86,7 @@ export const CallOutExample = {
       title: 'Info',
       source: [
         {
-          type: GuideSectionTypes.JS,
+          type: GuideSectionTypes.TSX,
           code: infoSource,
         },
       ],
@@ -107,7 +107,7 @@ export const CallOutExample = {
       title: 'Success',
       source: [
         {
-          type: GuideSectionTypes.JS,
+          type: GuideSectionTypes.TSX,
           code: successSource,
         },
       ],
@@ -125,7 +125,7 @@ export const CallOutExample = {
       title: 'Warning',
       source: [
         {
-          type: GuideSectionTypes.JS,
+          type: GuideSectionTypes.TSX,
           code: warningSource,
         },
       ],
@@ -141,7 +141,7 @@ export const CallOutExample = {
       title: 'Danger',
       source: [
         {
-          type: GuideSectionTypes.JS,
+          type: GuideSectionTypes.TSX,
           code: dangerSource,
         },
       ],

diff --git a/src/components/call_out/call_out.tsx b/src/components/call_out/call_out.tsx
@@ -52,7 +52,7 @@ export const EuiCallOut = forwardRef<HTMLDivElement, EuiCallOutProps>(
       iconType,
       children,
       className,
-      heading,
+      heading = 'p',
       ...rest
     },
     ref: Ref<HTMLDivElement>
@@ -102,10 +102,9 @@ export const EuiCallOut = forwardRef<HTMLDivElement, EuiCallOutProps>(
       );
     }
 
-    const H: any = heading ? `${heading}` : 'p';
     let header;
-
     if (title) {
+      const H: Heading = heading;
       header = (
         <EuiTitle size={size === 's' ? 'xxs' : 'xs'} css={cssHeaderStyles}>
           <H className="euiCallOutHeader__title">
@@ -115,6 +114,7 @@ export const EuiCallOut = forwardRef<HTMLDivElement, EuiCallOutProps>(
         </EuiTitle>
       );
     }
+
     return (
       <EuiPanel
         borderRadius="none"