Skip to content

Commit

Permalink
Fix undeclared module dependencies in eui.d.ts (#2828)
Browse files Browse the repository at this point in the history
* move @types enzyme and react-virtualized; exclude chart theme

* CL
  • Loading branch information
thompsongl authored Feb 5, 2020
1 parent 90e956a commit aca04c7
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@
- Fixed `EuiCode`'s & `EuiCodeBlock`'s ability to accept non-string children ([#2792](https://github.com/elastic/eui/pull/2792)) ([#2820](https://github.com/elastic/eui/pull/2820))
- Fixed `EuiSearchBar`, `Query`, and `AST`'s ability to accept literal parenthesis characters ([#2791](https://github.com/elastic/eui/pull/2791))
- Fixed coloring of input fields when autofill is on in Chrome ([#2798](https://github.com/elastic/eui/pull/2798))
- Moved `@types/enzyme` and `@types/react-virtualized` to `dependencies` status ([#2828](https://github.com/elastic/eui/pull/2828))
- Removed `@elastic/charts` from inclusion in `eui.d.ts` output ([#2828](https://github.com/elastic/eui/pull/2828))

**Breaking changes**

Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,10 @@
],
"dependencies": {
"@types/chroma-js": "^1.4.3",
"@types/enzyme": "^3.1.13",
"@types/lodash": "^4.14.116",
"@types/numeral": "^0.0.25",
"@types/react-virtualized": "^9.18.7",
"@types/react-beautiful-dnd": "^10.1.0",
"chroma-js": "^2.0.4",
"classnames": "^2.2.5",
Expand Down Expand Up @@ -81,12 +83,10 @@
"@svgr/core": "5.0.1",
"@svgr/plugin-svgo": "^4.0.3",
"@types/classnames": "^2.2.6",
"@types/enzyme": "^3.1.13",
"@types/jest": "^24.0.6",
"@types/react": "^16.9.11",
"@types/react-dom": "^16.9.4",
"@types/react-is": "^16.7.1",
"@types/react-virtualized": "^9.18.7",
"@types/resize-observer-browser": "^0.1.1",
"@types/tabbable": "^3.1.0",
"@types/uuid": "^3.4.4",
Expand Down
1 change: 1 addition & 0 deletions scripts/dtsgenerator.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ const generator = dtsGenerator({
'src-framer/**/*',
'**/*.test.ts',
'**/*.test.tsx',
'src/themes/charts/*' // A separate d.ts file is generated for the charts theme file
],
resolveModuleId(params) {
if (
Expand Down

0 comments on commit aca04c7

Please sign in to comment.